MantisBT - ATutor
View Issue Details
0002726ATutorSessionpublic2006-08-19 09:342006-08-29 11:00
greg 
user2 
normalminorunable to reproduce
closedfixed 
 
1.5.3.3 
SVN
0002726: hardcoded firstname 2nd last names
get_login() and $_SESSION['login']

* In the function it is hard-coded as 1st Name + 2nd Name + Last Name. It constitutes an i18n bug.

http://atutor.ca/view/3/8595/1.html [^]

Not sure about this one. I don't see any hard coding in get_login()
No tags attached.
related to 0002725closed user2 Name not updated in session when profile is edited 
Issue History
2006-08-19 09:34gregNew Issue
2006-08-19 09:34gregAffects version => SVN
2006-08-21 07:26user2Note Added: 0002142
2006-08-21 10:35user2Relationship addedrelated to 0002725
2006-08-21 10:37user2Note Added: 0002145
2006-08-22 10:11user2Statusnew => resolved
2006-08-22 10:11user2Fixed in Version => 1.5.4
2006-08-22 10:11user2Resolutionopen => fixed
2006-08-22 10:11user2Assigned To => user2
2006-08-29 11:00user2Statusresolved => closed

Notes
(0002142)
user2   
2006-08-21 07:26   
get_login() and $_SESSION['login'] now return a full name. I have some notes on this:
* Bug: The variable is not updated when the profile settings change.
* In the function it is hard-coded as 1st Name + 2nd Name + Last Name. It constitutes an i18n bug.
* Some our scripts use the var exactly as a login. Now we have to edit them and add an extra SQL request. However, once we noticed this, it's not a problem any more, but it can make problems for other users.
* Last but not least. It's strange to see a function and variable called 'login' containing a full name. I think this surrogate was the faster way you chose, but it creates a confusion and has a large bug potential.
(0002145)
user2   
2006-08-21 10:37   
an admin option should be added specifying what the display name is:
- login
- first second last
- first second last (login)
- first (login)