MantisBT - ATutor
View Issue Details
0003500ATutorAdminpublic2008-07-21 02:252009-07-21 08:52
IndieRect 
cindy 
normalminoralways
closedfixed 
1.6.1 
1.6.2 
SVN
0003500: Patcher: i18n-related bug in JavaScript
In _mods/standard/patcher/patch_edit_interface.tmpl.php, a variable ACTION_HTML_TEMPLATE is assigned a large block of HTML text, including several langvars.
If one of those langvars containts single quotes ('), parsing the javascript fails, and the entire block of file manipulations (effectively, the patcher module as a whole) becomes unusable.
No tags attached.
Issue History
2008-07-21 02:25IndieRectNew Issue
2008-07-21 02:25IndieRectAffects version => SVN
2008-08-21 08:37gregNote Added: 0003142
2008-08-21 08:37gregAssigned To => cindy
2008-08-21 08:37gregStatusnew => assigned
2008-11-13 10:09gregNote Added: 0003329
2008-11-17 07:01cindyStatusassigned => resolved
2008-11-17 07:01cindyFixed in Version => 1.6.2
2008-11-17 07:01cindyResolutionopen => fixed
2008-11-17 07:01cindyNote Added: 0003383
2009-07-21 08:52gregStatusresolved => closed

Notes
(0003142)
greg   
2008-08-21 08:37   
look at before the fall release
(0003329)
greg   
2008-11-13 10:09   
bump
(0003383)
cindy   
2008-11-17 07:01   
Solution: use addslashes() to escape special chars.

SVN Revision: 8232

Affected script: mods/_standard/patcher/patch_edit_interface.tmpl.php