MantisBT - ATutor
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003528||ATutor||Tests/Surveys||public||2008-08-05 02:33||2008-08-21 09:33|
|Target Version||Fixed in Version||1.6.2|
|Summary||0003528: Multiple submission deletion + 7 bugfixes|
|Description||The diff attached enables group deletion of test submissions (tools/tests/results.php and tools/tests/delete_result.php). It replaces radio buttons with checkboxes and adds a "Select/unselect all" checkbox. It's a frequently used feature here, especially in self-assessment tests where attempts are usually not limited.|
Also, the diff fixes the following existing bugs (unless otherwise noted, they're in tools/tests/results.php):
1. Security: Instructors can delete arbitrary submissions in others' courses by tweaking a URL query (tools/tests/delete_result.php).
2. In the confirmation dialog, "%s" appears literally (tools/tests/delete_result.php).
3. "< em >Anonymous< /em >" (w/o spaces) appears literally in full name field in anonymous tests.
4. Table gets empty in anonymous tests when sorted by name or score (SQL query flaw).
5. Bogus full name in guest submissions.
6. There's no test title visible (though programmed to be there).
7. No error messages when clicking "Delete" with no items selected.
The diff is tested in 1.6.1 pl1 and should work under r7769 as there've been no changes there since. Please consider adding it to the trunk.
You might also want to rename "delete_result.php" to "delete_results.php" with appropriate changes to paths in these two files, and rename and/or update AT_FEEDBACK_RESULT_DELETED.
|Steps To Reproduce|
|Tags||No tags attached.|
|Attached Files|| results_group-delete_plus_bugfixes.diff (8,090) 2008-08-05 02:33|
|2008-08-05 02:33||IndieRect||New Issue|
|2008-08-05 02:33||IndieRect||File Added: results_group-delete_plus_bugfixes.diff|
|2008-08-05 02:33||IndieRect||Affects version||=> SVN|
|2008-08-08 03:17||IndieRect||Note Added: 0003118|
|2008-08-20 11:03||greg||Status||new => resolved|
|2008-08-20 11:03||greg||Fixed in Version||=> 1.6.2|
|2008-08-20 11:03||greg||Resolution||open => fixed|
|2008-08-20 11:03||greg||Assigned To||=> greg|
|2008-08-20 11:03||greg||Note Added: 0003130|
|2008-08-20 11:10||greg||Note Added: 0003131|
|2008-08-20 11:16||greg||Product Version||1.6.1 => 1.6.2|
|2008-08-21 09:33||greg||Status||resolved => closed|