MantisBT - ATutor
View Issue Details
0003686ATutorPatcherpublic2009-01-05 09:502009-07-21 08:50
cindy 
cindy 
normalminoralways
closedfixed 
1.6.3 
1.6.3 
SVN
0003686: Cannot replace multiple lines of code; dependant patch was repeatedly display in the following patches
1. When new line character in the replace-from string doesn't match the new line characters in the subject, the replacement doesn't happen.

2. Example: patch 2 has a dependant patch 1, patch 3, 4 are displayed after patch 1 and they don't have any dependant patch. On "patcher" page, patch 2, 3, 4 are all displayed that they have dependant patch 1.
No tags attached.
Issue History
2009-01-05 09:50cindyNew Issue
2009-01-05 09:50cindyAffects version => SVN
2009-01-05 09:54cindyStatusnew => resolved
2009-01-05 09:54cindyFixed in Version => 1.6.2
2009-01-05 09:54cindyResolutionopen => fixed
2009-01-05 09:54cindyAssigned To => cindy
2009-01-05 09:54cindyNote Added: 0003449
2009-01-05 09:55cindyStatusresolved => feedback
2009-01-05 09:55cindyResolutionfixed => reopened
2009-01-05 09:55cindyNote Added: 0003450
2009-01-05 09:55cindyStatusfeedback => resolved
2009-01-05 09:55cindyResolutionreopened => fixed
2009-01-05 09:55cindyNote Added: 0003451
2009-06-12 09:24gregProduct Version1.6.2 => 1.6.3
2009-06-12 09:32gregStatusresolved => new
2009-06-12 09:33gregStatusnew => resolved
2009-06-12 09:33gregFixed in Version1.6.2 => 1.6.3
2009-07-21 08:50gregStatusresolved => closed

Notes
(0003449)
cindy   
2009-01-05 09:54   
SVN Revision: 8295

Affected scripts:
mods/_standard/patcher/index_admin.php
mods/_standard/patcher/classes/Patch.class.php

Solution:
P1. modify function strReplace() in Patch.class.php
P2. reset variable $dependant_patch each time displaying a new patch row
(0003450)
cindy   
2009-01-05 09:55   
Patch 0006 on 1.6.2 is issued for this issue.
(0003451)
cindy   
2009-01-05 09:55   
Patch 0006 on 1.6.2 is issued for this issue.