MantisBT - ATutor
View Issue Details
0003982ATutor- no cat -public2009-11-04 03:542009-11-07 12:09
IndieRect 
cindy 
normalminoralways
closedfixed 
1.6.3 
1.6.4 
1.6.4
0003982: Gradebook update: students are compared by full name, not id
In 1.6.3, when updating or combining tests in gradebook, function get_studs_take_more_than_once() is used to check if those tests can be updated/combined.

For some reason, that function compares students' uniqueness by first_name + last_name, not by member_id.
Clearly, in large installations it leaves much space for collisions as there may well be several students with same first and last names.

Probably it was done because gradebook displays only first and last names everywhere, but I believe that had been a bad decision too.

My suggestions are:
1. Make that function check member_id.
2. Switch to displaying full student name everywhere in gradebook, preferably using get_display_name().
No tags attached.
Issue History
2009-11-04 03:54IndieRectNew Issue
2009-11-04 03:54IndieRectAffects version => SVN
2009-11-04 11:27gregStatusnew => assigned
2009-11-04 11:27gregAssigned To => cindy
2009-11-05 06:35cindyStatusassigned => resolved
2009-11-05 06:35cindyFixed in Version => 1.6.4
2009-11-05 06:35cindyResolutionopen => fixed
2009-11-05 06:35cindyNote Added: 0003822
2009-11-05 11:11gregStatusresolved => closed
2009-11-07 12:08gregAffects versionSVN => 1.6.4
2009-11-07 12:08gregStatusclosed => assigned
2009-11-07 12:09gregStatusassigned => closed

Notes
(0003822)
cindy   
2009-11-05 06:35   
SVN revision: 8869

Solution: check on member_id instead of first, last name in function get_studs_take_more_than_once() and accordingly change other scripts where this function is called.

Affected scripts:
mods/_standard/gradebook/lib/gradebook.inc.php
mods/_standard/gradebook/update_gradebook.php
mods/_standard/gradebook/edit_marks.php
mods/_standard/gradebook/verify_tests.php
mods/_standard/gradebook/gradebook_add_tests.php