MantisBT - ATutor
View Issue Details
0004609ATutorContentpublic2010-11-02 14:582011-08-18 13:04
harris 
harris 
normalmajoralways
closedfixed 
 
2.0.3 
SVN
0004609: Add AT_FORMAT_QUOTES to AT_FORMAT_ALL in constants.inc.php
We should add AT_FORMAT_QUOTES to AT_FORMAT_ALL.

I am not sure why it's not included ever since the beginning of this file. Is there a reason why AT_FORMAT_QUOTES is not included in that AT_FORMAT_ALL bitwise string?

By adding the quotes in, all the output of AT_print will have quotes turned into htmlentities. I don't see a reason why it should not be included, comments?
No tags attached.
related to 0004685closed harris Replace htmlentities_utf82() with htmlentities_utf8() for photos module 
Issue History
2010-11-02 14:58harrisNew Issue
2010-11-02 14:58harrisAffects version => SVN
2010-11-02 15:00harrisNote Added: 0004733
2010-11-02 15:02harrisRelationship addedparent of 0004607
2010-11-02 15:02harrisRelationship addedparent of 0004608
2010-12-16 14:37harrisAssigned To => harris
2010-12-16 14:37harrisStatusnew => assigned
2010-12-16 14:37harrisNote Added: 0004812
2010-12-16 14:37harrisAssigned Toharris => greg
2010-12-17 10:59harrisNote Added: 0004816
2011-01-07 14:25harrisAssigned Togreg => harris
2011-01-07 14:26harrisNote Added: 0004871
2011-01-07 16:41harrisNote Added: 0004872
2011-01-07 17:02harrisNote Added: 0004873
2011-01-10 17:39harrisNote Added: 0004874
2011-01-11 12:25harrisRelationship addedrelated to 0004685
2011-01-12 11:55harrisNote Added: 0004883
2011-01-12 12:37harrisNote Added: 0004886
2011-01-12 13:00harrisNote Added: 0004887
2011-01-12 13:00harrisStatusassigned => resolved
2011-01-12 13:00harrisFixed in Version => 2.0.3
2011-01-12 13:00harrisResolutionopen => fixed
2011-08-18 13:04gregNote Added: 0005175
2011-08-18 13:04gregStatusresolved => closed

Notes
(0004733)
harris   
2010-11-02 15:00   
Remember to change all AT_print() which uses htmlentities within. We have to remove htmlentities within those functions.

For future developments, AT_print() should be used for any output marked by its namespace in the constants.inc.php.
(0004812)
harris   
2010-12-16 14:37   
To be fixed in 2.1
(0004816)
harris   
2010-12-17 10:59   
Should wrap all output through AT_print() with the appropriate namespace in its 2nd parameter. Then we no longer need to use htlmentities() within AT_print().
(0004871)
harris   
2011-01-07 14:26   
mods/_core/backup/delete.php line46

removed htmlentities_utf8() from title, title is the filename which will not have the invalid chars.
(0004872)
harris   
2011-01-07 16:41   
replaced htmlentities_utf8() with AT_print on the following files:

backup/admin/edit.php
backup/admin/index.php
mods/_core/editor/editor_tabs/glossary.inc.php
include/lib/output.inc.php
mods/_core/editor/editor_tabs/edit.inc.php
mods/_core/editor/editor_tab_functions.inc.php
mods/_core/editor/edit_content.php
mods/_core/groups/create_automatic.php
mods/_core/groups/create_manual.php
mods/_core/groups/delete_group.php
mods/_core/groups/edit_group.php
mods/_core/groups/groups.php
mods/_core/groups/index.php
mods/_core/groups/members.php
(0004873)
harris   
2011-01-07 17:02   
adding a new field_formatting to constants,

$_field_formatting['input.text']= AT_FORMAT_QUOTES;

same idea as htmlentities_utf8() but more consistence across ATutor.
(0004874)
harris   
2011-01-10 17:39   
blogs/
faqs/
links/
polls/

*/sublinks.php
(0004883)
harris   
2011-01-12 11:55   
social/*
photos/
reading_list/delete_reading.php
reading_list/delete_resource.php
reading_list/delete_resources.php
reading_list/edit_reading_av.php
reading_list/edit_reading_book.php
reading_list/edit_reading_file.php
reading_list/edit_reading_handout.php
reading_list/edit_reading_url.php
themes/default/social/*
(0004886)
harris   
2011-01-12 12:37   
Disabled HTML in the following modules:

Polls
Reading List
Groups
Photo Album
Social

Admins can turn these options on by altering the bitwise flags in include/constants.inc.php: $_field_formation
(0004887)
harris   
2011-01-12 13:00   
svn: 10609
(0005175)
greg   
2011-08-18 13:04   
first round of 2.0.3 changes closed