MantisBT - ATutor
View Issue Details
0004704ATutorContentpublic2011-01-20 13:592012-07-26 09:59
cindy 
cindy 
highminoralways
closedfixed 
2.0.2 
2.0.32.1 
SVN
9c7b7d02b7b98f76e0ddb4e7642ef4c8d7ffff78
0004704: Editor -> Accessibility icon does not work properly
The temporary html that is sent to AChecker, with the content to validate, only contains the content itself, without plugging into a html template. So, before AChecker starts validation, it wraps the content within <html>...</html>, which is not thorough enough. The fix is to,

mods/_core/editor/editor_tab_functions.inc.php -> write_temp_file() -> uncomment the part that the content is plugged into a template;

mods/_core/editor/accessibility.php -> add "offset=10" into $checker_url
No tags attached.
Issue History
2011-01-20 13:59cindyNew Issue
2011-02-04 14:41cindyNote Added: 0005045
2011-07-18 16:27gregAssigned To => cindy
2011-07-18 16:27gregStatusnew => assigned
2011-08-25 09:22gregNote Added: 0005229
2011-08-25 15:56cindyNote Added: 0005244
2012-07-23 10:54gregNote Added: 0005680
2012-07-24 10:08cindySVN Revision# => 9c7b7d02b7b98f76e0ddb4e7642ef4c8d7ffff78
2012-07-24 10:08cindyNote Added: 0005683
2012-07-24 10:08cindyStatusassigned => resolved
2012-07-24 10:08cindyFixed in Version => 2.1
2012-07-24 10:08cindyResolutionopen => fixed
2012-07-26 09:59gregNote Added: 0005718
2012-07-26 09:59gregStatusresolved => closed

Notes
(0005045)
cindy   
2011-02-04 14:41   
It turns out the comment-out the part in write_temp_file() to plug the content into a html template is because AChecker handles partial html by wrapping it into a simple template with doctype and <html>. This gets rid of the errors that is caused by the absence of <html>.

So the question is, should we let AChecker to handle the partial html, or, ATutor sends complete html to AChecker?
(0005229)
greg   
2011-08-25 09:22   
bump
(0005244)
cindy   
2011-08-25 15:56   
Note that accessibility checking doesn't work with localhost server. A message should be given if the validation is performed from localhost.

One issue of letting AChecker to check on partial html is that the returned report starts from line 2 instead of line 1. This issue has been reported in AChecker @ http://atutor.ca/atutor/mantis/view.php?id=4834 [^]
(0005680)
greg   
2012-07-23 10:54   
AChecker tinymce plugin does not open when using IE9.
(0005683)
cindy   
2012-07-24 10:08   
Solution: Fixed the IE9 issue by upgrading tinyMCE to the latest 1.5.5 version.

Affected:
jscripts/tiny_mce/*.*
(0005718)
greg   
2012-07-26 09:59   
close for ATutor 2.1