|Anonymous | Login | Signup for a new account||2018-05-23 16:07 EDT|
|My View | View Issues | Change Log | Roadmap | Repositories | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002285||ATutor||Modules||public||2006-01-05 07:14||2006-05-02 06:18|
|Target Version||Fixed in Version||1.5.3|
|Summary||0002285: new modules in svn|
|Description||why aren't the new modules in SVN?|
DONE in the phpmyadmin module change all mysql_query($sql) to mysql_query($sql, $db).
DONE and $phpmyadmin_url = addslashes(stripslashes($_REQUEST['phpmyadmin_url'])); isn't correct if magic_quotes isn't enabled.
DONE and shouldn't be using INSERT and UPDATE. a single REPLACE will do.
DONE and don't use select *. and don't use mysql_fetch_array()
DONE and use correct indenting and alternate if-statement notation within HTML.
DONE and buttons shouldn't be so verbose. "Save" "Open" is enough. no need for "Save phpMyAdmin Location" language.
DONE and no need to define AT_PRIV_PHPMYADMIN since there is no instructor priv.
DONE and phpmyadmin should NOT be an assignable privilege! any admin with such priv can just get the password of any super admin or even change their priv.
|Tags||No tags attached.|
phpmyadmin doesn't have a cancel button when editing.
the form divs aren't nested correctly.
why not just have the edit form within the edit box? could do the same thing.
edited on: 2006-01-05 11:26
DONE phpmyadmin selects from the db to get the config data. that's not needed.
|same issues with the ccnet module.|
|2006-01-05 07:14||user2||New Issue|
|2006-01-05 07:16||user2||Description Updated|
|2006-01-05 10:11||user2||Note Added: 0001729|
|2006-01-05 10:12||user2||Note Added: 0001730|
|2006-01-05 11:26||user2||Description Updated|
|2006-01-05 11:26||user2||Note Edited: 0001730|
|2006-01-06 07:34||user2||Note Added: 0001734|
|2006-01-06 09:45||user2||Status||new => resolved|
|2006-01-06 09:45||user2||Fixed in Version||=> 1.5.3|
|2006-01-06 09:45||user2||Resolution||open => fixed|
|2006-01-06 09:45||user2||Assigned To||=> user2|
|2006-05-02 06:18||user2||Status||resolved => closed|
|Copyright © 2000 - 2018 MantisBT Team|