|Anonymous | Login | Signup for a new account||2018-02-22 21:06 EST|
|My View | View Issues | Change Log | Roadmap | Repositories | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003556||ATutor||Upgrading||public||2008-09-07 00:08||2008-11-14 08:22|
|Target Version||Fixed in Version||1.6.2|
|Summary||0003556: Repetitive table alterations during upgrade|
|Description||If altering some tables on upgrade step 2 fails and user presses "Retry" then the upgrade script seems to repeat altering ALL tables, not only those that failed.|
In 1.6.1pl1 it may cause an inability to log in:
I had to press the button several times, and, as a result, found passwords in the DB to be equal to sha1(sha1(sha1(sha1(password)))).
If altering any tables on upgrade step 2 fails, the script should retry altering only those tables, not all.
|Tags||No tags attached.|
So this is what causes some failures on users log in.
Thanks for finding this out.
ustep2 runs through a series of sql statements through the .sql file. When a query failed and the user was asked to retry, all the .sql files will be run again and thus the repeated password encryption.
A quick fix to this is to run the encryption line iff the ||password|| < 40, because only then the pre161 non-SHA1 encrypted password will be converted. Given that the db password length was only 20.
|2008-09-07 00:08||IndieRect||New Issue|
|2008-09-07 00:08||IndieRect||Affects version||=> SVN|
|2008-09-08 07:56||harris||Note Added: 0003166|
|2008-11-10 09:25||harris||Status||new => assigned|
|2008-11-10 09:25||harris||Assigned To||=> harris|
|2008-11-10 09:28||harris||Status||assigned => resolved|
|2008-11-10 09:28||harris||Fixed in Version||=> 1.6.2|
|2008-11-10 09:28||harris||Resolution||open => fixed|
|2008-11-10 09:28||harris||Note Added: 0003290|
|2008-11-14 08:22||greg||Status||resolved => closed|
|Copyright © 2000 - 2018 MantisBT Team|