MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0005174ATutor- no cat -public2013-01-31 12:012014-08-10 09:50
Reporteranovak 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
PlatformOSOS Version
Product Version2.1.1 
Target Version2.1.1Fixed in Version 
Summary0005174: There are static function calls for functions which are not declared as static in ATutor code
DescriptiontestQuestion.class.php line 101: $question_classes = TestQuestions::getQuestionClasses();

take_test.php line 88: $obj = TestQuestions::getQuestion($row['type']);

take_test.php line 239: $obj = TestQuestions::getQuestion($row['type']);

Both of those functions getQuestionClasses() and getQuestion() are not declared as static functions. Hence there are lots of errors in the php.log
TagsNo tags attached.
Affects versionSVN
SVN Revision#
Attached Files

- Relationships

-  Notes
(0005948)
geetakshi (developer)
2013-02-03 13:00

I have made a pull request to fix this bug - https://github.com/atutor/ATutor/pull/32 [^]
Is there any specific reason to why static keyword was commented out in the methods?
(0006061)
greg (administrator)
2013-02-15 10:39

The pull request was rejected because it is not clear why static has been commented out. They were likely commented for a reason, so there would need to be a full set of tests done to ensure doing so does not introduce other problems.
(0006912)
greg (administrator)
2014-08-10 09:50

bump

- Issue History
Date Modified Username Field Change
2013-01-31 12:01 anovak New Issue
2013-02-03 13:00 geetakshi Note Added: 0005948
2013-02-15 10:39 greg Note Added: 0006061
2013-02-19 15:45 greg Severity major => minor
2014-08-10 09:50 greg Note Added: 0006912


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker