Community Forums

ATutor Bug Reports

1.5.5: bug with custom course icon


You must be signed-in to post.

AuthorSubject
 
Page: 1
vegard

Avatar for vegard
customicon.png

Attachment: customicon.png
Subject: 1.5.5: bug with custom course iconQuote this post in your reply
hi, discovered a bug when uploading a custom course icon in 1.5.5.

upload the icon, and everything works fine. however, go back to the course properties page via manage -> properties and the save button plus the footer information is gone. you are not able to save any changes you do in the preferences after this.

you are still able to change these as admin though, from courses -> [the course] -> edit.

I was not able to reproduce this in the 1.6.1 demo server, but it would be nice if anyone could test this on their 1.5.5 system!

see attached screenshot
Posted: 2008-06-03 03:43:20
vegard

Avatar for vegard
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
I'm getting the same bug on 1.6.1 beta 2 at my production server, but not at localhost..

could this be a permission problem? I see that the content/1/custom_icons/testicon.jpg has permission -rw-r--r--

(I can see the icon though)
Posted: 2008-06-03 06:29:11
harris

Avatar for harris
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
Could be a path problem.. for the malfunction system, is the content/ folder outside of the ATutor installation?
Posted: 2008-06-03 09:52:24
vegard

Avatar for vegard
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
on my production system it is outside, but on 1.6.1 b2 on the same server it is inside, and I get the bug there too..
Posted: 2008-06-03 09:54:09
harris

Avatar for harris
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
I can modify the course property and icons just fine with the instructors.

However, if I am editing the course properties with the admin, it doesn't work. I am thinking this could be a path problem.
Posted: 2008-06-03 10:21:58
vegard

Avatar for vegard
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
weird, as that's the opposite of me. it's broken for instructor, but I can modify it as admin.

it seems it doesn't include / print much after the icon, so you might very well be right about the path.

didn't find your e-mail right away, but Greg got access to a server if you'd like to have a look!
Posted: 2008-06-03 14:58:13
vegard

Avatar for vegard
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
FYI: this is an ownership issue, all course folders in the content directory is owned by the webserver, which is fine.

if I change the ownership to me with chown for the course folder, the custom_icons folder and the actual icon, I get the save / upload functionality again, but then the server cannot show the image..

so, have no idea why, or what to do with that, but the issue must be related to this somehow..
Posted: 2008-06-17 06:34:23
gorzan

Avatar for gorzan
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
Okay, so I solved this problem but spawned a fresh one.

a) Problem is related to PHP versions - the /include/html/course_properties.inc.php file uses the scandir function to list all custom icons for the course, but this function is php5 only, and for some reason this results in php halting on our server (php 4.3.x) when logged in as instructor but not as admin. Not sure why, but fixed this by switching the scandir function for a php4 equivalent solution. (Does ATutor require php5? If not, this should be changed in core.)

b) A new problem was discovered minutes after this one was solved. Having restored the option to upload custom icons one of our coworkers hit the wall when trying to upload an icon of ~4 MB. Apparently there is a hardcoded limit to icon files of about 800kB, regardless of what limit is set for files to the course. This wouldn't normally have been a big issue, but in addition to being denied the upload, all html in the banner field in course properties was now escaped by slashes (\), and \n and \r were scattered through the banner field, making the course front page rather ugly. Dunno where this came from, but hope this bug can be fixed so that our instructors don't mess up the courses when they try to change icons.
Posted: 2008-06-19 07:21:49
gorzan

Avatar for gorzan
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
solved b) as well. Want me to submit the revised file or a patch anywhere?
Posted: 2008-06-19 08:24:54
greg

Avatar for greg
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
Attach the patch to this thread
Posted: 2008-06-19 10:02:09
gorzan

Avatar for gorzan
gorzan_cpreffix.zip

Attachment: gorzan_cpreffix.zip
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
Allright, here it is. Made it for 1.6.1 since thats the version we'll be running when its out anyway.
Posted: 2008-06-20 05:42:47
greg

Avatar for greg
Subject: Re: 1.5.5: bug with custom course iconQuote this post in your reply
thanks Gorzan. The patch has been applied and should make it into tonight's nightly build.
Posted: 2008-06-20 09:12:17
 
Page: 1

You must be signed-in to post.

Related Articles